refactor: extract webhook submission logic into a `useWebhookSubmit` by Manishnemade12 · Pull Request #7537 · layer5io/layer5

Manishnemade12 · 2026-03-22T06:40:42Z

Description

This PR fixes #7536

This PR abstracts and centralizes the duplicated webhook submission logic by introducing a custom useWebhookSubmit hook. It integrates this new hook into the CommonForm (index.js and events.js) and ContactForm (index.js) components. Previously, these forms used an unhandled axios.post inside a useEffect triggered by a state flag, which risked silent data loss on network failure. By awaiting the network requests directly inside the Formik onSubmit handlers, we ensure the UI transitions to the "Thank You" screen only upon a confirmed HTTP success.

Notes for Reviewers

The new hook is located at src/utils/hooks/useWebhookSubmit.js.
This change affects /contact, /community/events, and other form pages.
To test locally: Submit a form and verify it proceeds to the success step. If you drop your network connection before submitting, it will correctly alert you of the failure and retain your form state instead of showing a false success.

Signed commits

Yes, I signed my commits.

Copilot

Pull request overview

This PR centralizes webhook submission logic into a new useWebhookSubmit hook and updates existing forms to await submissions in Formik’s onSubmit, preventing false-positive “success” UI transitions when requests fail.

Changes:

Added useWebhookSubmit hook to encapsulate axios submission state + error handling.
Refactored CommonForm, EventForm, and ContactForm to submit via the hook inside onSubmit (removing prior useEffect-triggered posts).
Added basic failure handling (alerts) and kept success scrolling behavior within the submit flow.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File	Description
src/utils/hooks/useWebhookSubmit.js	Introduces a reusable hook to submit payloads to the Make.com webhook and track submission/error state.
src/components/ContactForm/index.js	Switches to awaiting webhook submission in `onSubmit` and only transitions UI on success.
src/components/CommonForm/index.js	Replaces `useEffect`-based post with awaited submit and gates success step on confirmed submission.
src/components/CommonForm/events.js	Refactors event form submission to use the hook and handle failure explicitly.

src/utils/hooks/useWebhookSubmit.js

src/components/ContactForm/index.js

src/components/CommonForm/index.js

src/components/CommonForm/events.js

…hook and integrate it into CommonForm and ContactForm components. Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

l5io · 2026-03-22T07:00:36Z

🚀 Preview for commit 709d5f4 at: https://69bf9360215bccffd0afcbeb--layer5.netlify.app

l5io · 2026-03-22T08:31:27Z

🚀 Preview for commit c17fb1c at: https://69bfa8b06f2ab006b9de4b89--layer5.netlify.app

l5io · 2026-03-24T02:42:16Z

🚀 Preview for commit aeb3e68 at: https://69c1f9b6c87786311b23e0c6--layer5.netlify.app

Manishnemade12 · 2026-03-24T04:05:17Z

@CodexRaunak can you please review this pr

l5io · 2026-03-24T06:36:11Z

🚀 Preview for commit b1f5d72 at: https://69c230ab39fb22adc0c2d56b--layer5.netlify.app

Manishnemade12 · 2026-03-25T08:56:31Z

@saurabhraghuvanshii can you please review this pr

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manish Nemade <166635137+Manishnemade12@users.noreply.github.com>

l5io · 2026-03-25T09:19:42Z

🚀 Preview for commit 9dede11 at: https://69c3a8772f6d231371e28811--layer5.netlify.app

l5io · 2026-03-25T13:00:20Z

🚀 Preview for commit bff7508 at: https://69c3dc33a1de532588f1acdb--layer5.netlify.app

Manishnemade12 · 2026-03-26T05:59:16Z

@saurabhraghuvanshii can you please review this pr

l5io · 2026-03-26T06:15:33Z

🚀 Preview for commit 96f097d at: https://69c4cecb8748eee6140f5f36--layer5.netlify.app

src/components/CommonForm/events.js

l5io · 2026-03-28T14:32:55Z

🚀 Preview for commit f744db5 at: https://69c7e653c5238f112a3bf1aa--layer5.netlify.app

Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

Manishnemade12 · 2026-03-28T18:17:26Z

@rishiraj38 i addressed your changes can you please review it now

l5io · 2026-03-28T18:33:13Z

🚀 Preview for commit 185c96e at: https://69c81ea05353dd80e8a52b9b--layer5.netlify.app

Manishnemade12 · 2026-04-03T05:40:41Z

@saurabhraghuvanshii can you please review this pr

l5io · 2026-04-03T05:59:43Z

🚀 Preview for commit 5b5f726 at: https://69cf571d9fc8b8195bffb68c--layer5.netlify.app

rishiraj38

Please take a look on copilot review

src/components/CommonForm/events.js

Manishnemade12 · 2026-04-03T09:18:25Z

@rishiraj38 Replaced the blocking alert() on form submission failure with an inline, accessible error message using Formik status and an aria-live region. This keeps users in context, improves accessibility, and avoids disruptive browser modals.

Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

l5io · 2026-04-03T09:37:05Z

🚀 Preview for commit f5f5384 at: https://69cf8a11fa0a08bd41a76430--layer5.netlify.app

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

src/utils/hooks/useWebhookSubmit.js

src/components/ContactForm/index.js

src/components/CommonForm/index.js

src/components/CommonForm/events.js

rishiraj38

Please also change the alerts in these lines.

src/components/CommonForm/index.js

src/components/ContactForm/index.js

…d ContactForm Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

Manishnemade12 · 2026-04-05T06:11:07Z

@rishiraj38 i Replaced alert("Submission failed...") in both index.js and index.js with Formik setStatus + inline accessible error UI (role="alert", aria-live="assertive").
Also clear error status on successful submit (setStatus(null)) .

rishiraj38 · 2026-04-05T08:18:29Z

Please take a look at copilot suggestions.

Manishnemade12 · 2026-04-05T13:31:06Z

Please take a look at copilot suggestions.

@rishiraj38 i addressed all Copilot comments

saurabhraghuvanshii · 2026-04-05T15:43:05Z

@Manishnemade12 Please present it tommorow meeting https://meet.layer5.io/websites-minutes

github-actions · 2026-04-07T04:58:22Z

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

arjunmehta-git · 2026-04-09T07:38:20Z

This is a meaningful reliability improvement, @Manishnemade12. The core insight — that an unhandled axios.post inside a useEffect triggered by a state flag can silently succeed from the UI's perspective while the network request fails — is exactly the kind of subtle bug that's easy to miss and hard to debug in production. Moving to await-ing the request directly in Formik's onSubmit is the correct pattern.

A few things still blocking merge:

DCO sign-off missing — The git-police bot flagged that one or more commits lack a sign-off. Please amend those commits with git commit --amend -s (or rebase with --signoff) before this can merge. This is a hard requirement.
Copilot review suggestions — @rishiraj38 asked you to address the Copilot review comments. Please confirm all of those are resolved and mark the conversation threads as resolved so reviewers can see the current state clearly.
Inline error UI — The switch from alert() to Formik status with role="alert" / aria-live="assertive" is the right call for accessibility. Good initiative on that addition.

Once the DCO is fixed and the review threads are resolved, this is close to mergeable.

…mit hook Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

Manishnemade12 · 2026-04-09T13:30:27Z

@rishiraj38 @arjunmehta-git i resolved all copilot comments and and dco signoff issue
so please review it whenever you get time .

Copilot AI review requested due to automatic review settings March 22, 2026 06:40

Copilot AI reviewed Mar 22, 2026

View reviewed changes

refactor: extract webhook submission logic into a useWebhookSubmit …

709d5f4

…hook and integrate it into CommonForm and ContactForm components. Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

Manishnemade12 force-pushed the eliminate branch from a99476c to 709d5f4 Compare March 22, 2026 06:44

Merge branch 'master' into eliminate

c17fb1c

Manishnemade12 closed this Mar 22, 2026

Manishnemade12 reopened this Mar 24, 2026

Merge branch 'master' into eliminate

aeb3e68

Merge branch 'master' into eliminate

b1f5d72

Update src/utils/hooks/useWebhookSubmit.js

9dede11

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manish Nemade <166635137+Manishnemade12@users.noreply.github.com>

Merge branch 'master' into eliminate

bff7508

saurabhraghuvanshii requested review from YASHMAHAKAL and rishiraj38 March 25, 2026 12:49

Merge branch 'master' into eliminate

96f097d

rishiraj38 reviewed Mar 26, 2026

View reviewed changes

src/components/CommonForm/events.js Outdated Show resolved Hide resolved

Merge branch 'master' into eliminate

f744db5

Remove unnecessary state update in EventForm on successful submission

185c96e

Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

Manishnemade12 requested a review from rishiraj38 March 28, 2026 18:17

Merge branch 'master' into eliminate

5b5f726

rishiraj38 reviewed Apr 3, 2026

View reviewed changes

src/components/CommonForm/events.js Show resolved Hide resolved

Manishnemade12 requested a review from rishiraj38 April 3, 2026 09:18

fix(forms): replace alert with inline error status

f5f5384

Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

Manishnemade12 force-pushed the eliminate branch from 9c1088f to f5f5384 Compare April 3, 2026 09:21

saurabhraghuvanshii requested a review from Copilot April 3, 2026 21:11

Copilot AI reviewed Apr 3, 2026

View reviewed changes

src/utils/hooks/useWebhookSubmit.js Show resolved Hide resolved

src/components/ContactForm/index.js Outdated Show resolved Hide resolved

src/components/CommonForm/index.js Outdated Show resolved Hide resolved

src/components/CommonForm/events.js Outdated Show resolved Hide resolved

Merge branch 'master' into eliminate

9359f93

rishiraj38 reviewed Apr 4, 2026

View reviewed changes

src/components/CommonForm/index.js Outdated Show resolved Hide resolved

src/components/ContactForm/index.js Outdated Show resolved Hide resolved

fix(form): enhance error handling and status display in CommonForm an…

271d732

…d ContactForm Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

YASHMAHAKAL added the issue/dco Commit sign-off instructions label Apr 7, 2026

fix(forms): remove unused state and add unmount safety to webhook sub…

3ccd76f

…mit hook Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

Manishnemade12 force-pushed the eliminate branch from d916c52 to 7cb3d5b Compare April 9, 2026 13:17

Merge branch 'master' into eliminate

3455552

Signed-off-by: Manishnemade12 <mnemade140@gmail.com>

Manishnemade12 force-pushed the eliminate branch from 7cb3d5b to 3455552 Compare April 9, 2026 13:22

Manishnemade12 requested a review from rishiraj38 April 10, 2026 04:46

Merge branch 'master' into eliminate

cfb6655

Conversation

Manishnemade12 commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

l5io commented Mar 22, 2026

Uh oh!

l5io commented Mar 22, 2026

Uh oh!

l5io commented Mar 24, 2026

Uh oh!

Manishnemade12 commented Mar 24, 2026

Uh oh!

l5io commented Mar 24, 2026

Uh oh!

Manishnemade12 commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

l5io commented Mar 25, 2026

Uh oh!

l5io commented Mar 25, 2026

Uh oh!

Manishnemade12 commented Mar 26, 2026

Uh oh!

l5io commented Mar 26, 2026

Uh oh!

Uh oh!

l5io commented Mar 28, 2026

Uh oh!

Manishnemade12 commented Mar 28, 2026

Uh oh!

l5io commented Mar 28, 2026

Uh oh!

Manishnemade12 commented Apr 3, 2026

Uh oh!

l5io commented Apr 3, 2026

Uh oh!

rishiraj38 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Manishnemade12 commented Apr 3, 2026

Uh oh!

l5io commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rishiraj38 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Manishnemade12 commented Apr 5, 2026

Uh oh!

rishiraj38 commented Apr 5, 2026

Uh oh!

Manishnemade12 commented Apr 5, 2026

Uh oh!

saurabhraghuvanshii commented Apr 5, 2026

Uh oh!

github-actions bot commented Apr 7, 2026

Uh oh!

arjunmehta-git commented Apr 9, 2026

Manishnemade12 commented Mar 22, 2026 •

edited

Loading

Manishnemade12 commented Mar 25, 2026 •

edited

Loading

Manishnemade12 commented Apr 9, 2026 •

edited

Loading